Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use hierarchical route as key for collecting client menus #2462

Merged
merged 5 commits into from
May 24, 2024
Merged

fix: use hierarchical route as key for collecting client menus #2462

merged 5 commits into from
May 24, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented May 23, 2024 •
edited
Loading

Fixes #2460

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@codecov Codecov
Copy link

codecov bot commented May 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.4@cd46d72). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             24.4    #2462   +/-   ##
=======================================
  Coverage        ?   95.17%           
=======================================
  Files           ?       66           
  Lines           ?     4535           
  Branches        ?      653           
=======================================
  Hits            ?     4316           
  Misses          ?      178           
  Partials        ?       41
Flag Coverage Δ
unittests 95.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as ready for review May 24, 2024 08:02
@taefi
Copy link
Contributor Author

taefi commented May 24, 2024

This should not be picked to main, as it is covered in #2449

@taefi taefi requested a review from Lodin May 24, 2024 08:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@platosha platosha merged commit f5cdf5f into 24.4 May 24, 2024
15 checks passed
@platosha platosha deleted the taefi/fix-2460 branch May 24, 2024 08:45
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.beta5 and is also targeting the upcoming stable 24.4.0 version.

@taefi taefi mentioned this pull request May 24, 2024
Closed
@vaadin-bot
Copy link
Collaborator

Hi @taefi and @platosha, when i performed cherry-pick to this commit to main, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick f5cdf5f
error: could not apply f5cdf5f... fix: use hierarchical route as key for collecting client menus (#2462)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Lodin pushed a commit that referenced this pull request Jun 5, 2024
@taefi @Lodin
fix: use hierarchical route as key for collecting client menus (#2462)
b883aaa
platosha pushed a commit that referenced this pull request Jun 5, 2024
@Lodin @taefi
fix: use hierarchical route as key for collecting client menus (#2462)…
42e9150 
… (CP: main) (#2504)

fix: use hierarchical route as key for collecting client menus (#2462)

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lodin Lodin Lodin approved these changes

Assignees
No one assigned
Labels
cherry-picked-main prerelease version for Hilla 24.4.0 Released with Hilla 24.4.0.beta5 target/main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taefi @vaadin-bot @Lodin @platosha